Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GrantFund Deployer contract #125

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Add GrantFund Deployer contract #125

merged 5 commits into from
Oct 13, 2023

Conversation

prateek105
Copy link
Contributor

Description of change

High level

  • Add deployer contract to deploy grant fund, fund treasury, and startNewDistribution.

@prateek105 prateek105 marked this pull request as ready for review August 4, 2023 13:48
grandizzy
grandizzy reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments added

src/grants/Deployer.sol Show resolved Hide resolved
src/grants/Deployer.sol Outdated Show resolved Hide resolved
@grandizzy
Copy link
Contributor

Was also thinking if would make sense to have a set of require at the end, that is to assert that grant fund properly created / funded / distribution started (e.f. check treasury and contract balance, check distribution, others)

grandizzy
grandizzy approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changes, lgtm

EdNoepel
EdNoepel approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I look forward to testing this on Goerli.

ith-harvey
ith-harvey approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ith-harvey ith-harvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel merged commit 0a7edb0 into develop Oct 13, 2023
@EdNoepel EdNoepel deleted the grantfund-deployer branch October 13, 2023 14:33
MikeHathaway
MikeHathaway approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel restored the grantfund-deployer branch October 13, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdNoepel EdNoepel EdNoepel approved these changes

@grandizzy grandizzy grandizzy approved these changes

@ith-harvey ith-harvey ith-harvey approved these changes

@MikeHathaway MikeHathaway MikeHathaway approved these changes

@mattcushman mattcushman Awaiting requested review from mattcushman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prateek105 @grandizzy @MikeHathaway @ith-harvey @EdNoepel